[FFmpeg-devel] [PATCH v1] avfilter: add overlay vaapi filter

[Moritz Barsnick]

On Fri, Dec 20, 2019 at 10:55:39 +0800, Xinpeng Sun wrote:
> +Set blocking detection thresholds. Allowed range is 0.0 to 1.0, it
> +need input video has alpha channel.

Incorrect grammar. I suggest ", it requires an input video with alpha
channel".

> +    ret = ff_formats_ref(ff_make_format_list(main_in_fmts), &ctx->inputs[MAIN]->out_formats);
> +    if (ret < 0)
> +      return ret;
> +
> +    ret = ff_formats_ref(ff_make_format_list(main_in_fmts), &ctx->inputs[OVERLAY]->out_formats);
> +    if (ret < 0)
> +      return ret;

Incorrect indentation (twice).

> +    if (!support_flag) {
> +      av_log(avctx, AV_LOG_ERROR, "VAAPI driver doesn't support global alpha blending\n");
> +        return AVERROR(EINVAL);

Incorrect indentation.

Moritz