[FFmpeg-devel] [PATCH] [PATCH] avcodec: Fix h264_videotoolbox writing b-frames (fix ticket #8353)

[Nomis101]

Am 27.02.20 um 19:13 schrieb Nomis101:
> Signed-off-by: Nomis101 <Nomis101 at web.de>
> ---
>  libavcodec/videotoolboxenc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index cc08cf6a50..32d893e485 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -1355,6 +1355,7 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
>          vtctx->get_param_set_func = compat_keys.CMVideoFormatDescriptionGetHEVCParameterSetAtIndex;
>          if (!vtctx->get_param_set_func) return AVERROR(EINVAL);
>          if (!get_vt_hevc_profile_level(avctx, &profile_level)) return AVERROR(EINVAL);
> +        vtctx->has_b_frames = avctx->max_b_frames > 0;
>      }
>
>      enc_info = CFDictionaryCreateMutable(
> --
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>


Just to clarify, what this patch does. It will fix trac.ffmpeg.org/ticket/8353 "h264_videotoolbox is not writing b-frames".
The fix is adopted from HandBrake's FFmpeg patch set: https://github.com/HandBrake/HandBrake/blob/master/contrib/ffmpeg/A04-videotoolbox.patch