[FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

[Carl Eugen Hoyos]

Am So., 23. Feb. 2020 um 23:43 Uhr schrieb James Darnley
<james.darnley at gmail.com>:
>
> On 2020-02-23 18:58, Michael Niedermayer wrote:
> > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote:
> >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer
> >> <michael at niedermayer.cc>:
> >>>
> >>> From: Parker Ernest <@>
> >>>
> >>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on
> >>> x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II
> >>
> >> Does the commit break build on specific CPUs or specific toolchains?
> >
> > I dont know what the testcase was the author encountered, i just posted
> > this here as the author wanted me to post it for him.
> > but a simple
> > make distclean ; ./configure --disable-ssse3 && make -j32
> > replicates the build failure here (see below for the errors)
>
> Okay, it breaks the build when you do --disable-sse3.  I see that too.
>
> It is okay to fix that any way you want.  This patch is fine by me but

> please don't imply that it fixes a run time error in the commit message,
> which is what I first thought.

I also feel that mentioning a specific cpu instead of --disable-ssse3 is
misleading.

Carl Eugen