[FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

[Moritz Barsnick]

On Mon, Feb 17, 2020 at 18:34:34 +0100, Carl Eugen Hoyos wrote:
> Am 17.02.2020 um 10:49 schrieb Zane van Iperen <zane at zanevaniperen.com>:
> > There's no real "magic" fields to look for, hence why I set the `extensions`
> > field. What would a probe function do in this case?
>
> I cannot look at the files right now:
> Is there nothing that allows to distinguish them from random data?

I wonder too why there should be no magic data. The header function
already checks

+    if (vs12.magic != MKTAG('v', 's', '1', '2')) {

and

+    if (avio_rl32(s->pb) != MKTAG('D', 'A', 'T', 'A'))

Is this not magic? Is it not unique? Or at least a good hit justifying
some score?

Moritz