[FFmpeg-devel] [PATCH]lsws/input: Do not change transparency range

[Michael Niedermayer]

On Sat, Feb 15, 2020 at 10:10:45AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Transparency levels are currently changed when reading bgra and
> friends, this patch changes behaviour and fixes ticket #8509.
> 
> Please comment, Carl Eugen

>  libswscale/input.c                            |    6 
>  tests/ref/fate/ffmpeg-filter_colorkey         |   20 +-
>  tests/ref/fate/filter-overlay-dvdsub-2397     |  180 +++++++++++++-------------
>  tests/ref/fate/filter-overlay_gbrap_gbrap     |    2 
>  tests/ref/fate/filter-overlay_gbrp_gbrap      |    2 
>  tests/ref/fate/filter-overlay_yuv420_yuva420  |    2 
>  tests/ref/fate/filter-overlay_yuv422_yuva422  |    2 
>  tests/ref/fate/filter-overlay_yuv444_yuva444  |    2 
>  tests/ref/fate/filter-overlay_yuva420_yuva420 |    2 
>  tests/ref/fate/filter-overlay_yuva422_yuva422 |    2 
>  tests/ref/fate/filter-overlay_yuva444_yuva444 |    2 
>  11 files changed, 111 insertions(+), 111 deletions(-)
> d8ed3bafeca2ed15b41a2fca0dc5600e3aeab671  0001-lsws-input-Do-not-change-transparency-range.patch
> From a71053df9131be803d9a359a7232e5193747f351 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> Date: Sat, 15 Feb 2020 10:07:51 +0100
> Subject: [PATCH] lsws/input: Do not change transparency range.
> 
> Fixes ticket #8509.
[...]

> @@ -457,7 +457,7 @@ static void palToA_c(uint8_t *_dst, const uint8_t *src, const uint8_t *unused1,
>      for (i=0; i<width; i++) {
>          int d= src[i];
>  
> -        dst[i]= (pal[d] >> 24)<<6;
> +        dst[i]= (pal[d] >> 24)<<6 | pal[d]>>2;

this looks wrong, theres a 24 missing in some form

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200215/1c5772ee/attachment.sig>