[FFmpeg-devel] [PATCH 3/3] libfdk-aacdec: Allow explicitly disabling the DRC reference level option

[James Almer]

On 2/5/2020 10:12 AM, Martin Storsjö wrote:
> On Wed, 5 Feb 2020, James Almer wrote:
> 
>> On 2/5/2020 8:07 AM, Martin Storsjö wrote:
>>> Previously, it was always left in the automatic mode, if the option
>>> was set to the only special (negative) value. Now there's two separate
>>> special values for this option, -1 for automatic (metadata based)
>>> and -2 for explicitly disabled.
>>> ---
>>>  libavcodec/libfdk-aacdec.c | 10 ++++++++--
>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c
>>> index 32a97958c4..cc50fdce2f 100644
>>> --- a/libavcodec/libfdk-aacdec.c
>>> +++ b/libavcodec/libfdk-aacdec.c
>>> @@ -76,8 +76,8 @@ static const AVOption fdk_aac_dec_options[] = {
>>>                       OFFSET(drc_boost),      AV_OPT_TYPE_INT,   {
>>> .i64 = -1 }, -1, 127, AD, NULL    },
>>>      { "drc_cut",   "Dynamic Range Control: attenuation factor, where
>>> [0] is none and [127] is max compression",
>>>                       OFFSET(drc_cut),        AV_OPT_TYPE_INT,   {
>>> .i64 = -1 }, -1, 127, AD, NULL    },
>>> -    { "drc_level", "Dynamic Range Control: reference level,
>>> quantized to 0.25dB steps where [0] is 0dB and [127] is -31.75dB",
>>> -                     OFFSET(drc_level),      AV_OPT_TYPE_INT,   {
>>> .i64 = -1},  -1, 127, AD, NULL    },
>>> +    { "drc_level", "Dynamic Range Control: reference level,
>>> quantized to 0.25dB steps where [0] is 0dB and [127] is -31.75dB, -1
>>> for auto, and -2 for disabled",
>>
>> Not against adding this extra explanation here since this one is not a
>> simple boolean option, but i see there's no entry for fdk-aacdec in
>> decoders.texy, so could you add one with all the options described in it?
> 
> I'd say that's a separate issue from these patches - I could look into
> doing that, but that would be a later step.

Yes, it's a request, not a blocking comment.

> 
> // Martin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".