[FFmpeg-devel] [PATCH 1/2] lavc/dvdsubdec: Move palette parsing to new function

[Michael Niedermayer]

On Sat, Feb 01, 2020 at 11:43:08PM +0100, Michael Kuron wrote:
> Signed-off-by: Michael Kuron <michael.kuron at gmail.com>
> ---
>  doc/decoders.texi      |  2 +-
>  libavcodec/Makefile    |  1 +
>  libavcodec/dvdsub.c    | 33 +++++++++++++++++++++++++++++++++
>  libavcodec/dvdsubdec.c | 22 ++++++----------------
>  libavcodec/internal.h  |  2 ++
>  5 files changed, 43 insertions(+), 17 deletions(-)
>  create mode 100644 libavcodec/dvdsub.c
> 
> diff --git a/doc/decoders.texi b/doc/decoders.texi
> index 0582b018b0..83515ae363 100644
> --- a/doc/decoders.texi
> +++ b/doc/decoders.texi
> @@ -280,7 +280,7 @@ palette is stored in the IFO file, and therefore not available when reading
>  from dumped VOB files.
>  
>  The format for this option is a string containing 16 24-bits hexadecimal
> -numbers (without 0x prefix) separated by comas, for example @code{0d00ee,
> +numbers (without 0x prefix) separated by commas, for example @code{0d00ee,
>  ee450d, 101010, eaeaea, 0ce60b, ec14ed, ebff0b, 0d617a, 7b7b7b, d1d1d1,
>  7b2a0e, 0d950c, 0f007b, cf0dec, cfa80c, 7c127b}.

strictly speaking this should be a seperate patch

but execpt that, LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200202/c2ba8c3a/attachment.sig>