[FFmpeg-devel] [PATCH] patcheck: warn missing whitespace between ) and {

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Wed Dec 30 12:54:49 EET 2020


liuqi05:
> Signed-off-by: liuqi05 <liuqi05 at kuaishou.com>
> ---
>  tools/patcheck | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/patcheck b/tools/patcheck
> index fe52938f29..ca7b57f29f 100755
> --- a/tools/patcheck
> +++ b/tools/patcheck
> @@ -101,6 +101,7 @@ hiegrep2 "$ERE_TYPES" '(static|av_|ff_|typedef|:\+[^a-zA-Z_])' 'Non static with
>  hiegrep ':\+[^}#]*else' 'missing } prior to else' $*
>  hiegrep '(if|while|for)\(' 'missing whitespace between keyword and ( (feel free to ignore)' $*
>  hiegrep '(else|do){'       'missing whitespace between keyword and { (feel free to ignore)' $*
> +hiegrep '\){'              'missing whitespace between ) and { (feel free to ignore)' $*
>  hiegrep '}(else|while)'    'missing whitespace between } and keyword (feel free to ignore)' $*
>  
>  #FIXME this should print the previous statement maybe
> Missing whitespace is actually common in case of compound literals.

- Andreas


More information about the ffmpeg-devel mailing list