[FFmpeg-devel] [PATCH 1/4] avcodec/h264_sei: refactor parsing User Data Registered ITU-T T35 SEI messages

[James Almer]

On 12/18/2020 12:51 PM, Jan Ekström wrote:
> On Tue, Dec 8, 2020 at 9:44 PM James Almer <jamrial at gmail.com> wrote:
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   libavcodec/h264_sei.c | 31 ++++++++++++++++++++++---------
>>   1 file changed, 22 insertions(+), 9 deletions(-)
> 
> Set generally OK, just some minor things:
> - probably AVERROR(EINVAL) usage should be AVERROR_INVALIDDATA ?
> - Unrelated to this specific set (but just visible in the context of
> the change), but I see that we seem to have generally not handled the
> case of country_code == 0xFF && size == 7 (or 3). I think while we're
> refactoring this code we could just add a "if (size < 1) return
> AVERROR_INVALIDDATA;" into that country_code == 0xFF check? Should
> make it handle that specific case now.
> 
> Jan

Both things changed, and set pushed.

Thanks.