[FFmpeg-devel] [PATCH v3] avformat/framecrcenc: Make side-data checksums endian-independent

[Nicolas George]

Anton Khirnov (12020-12-13):
> IMO checksumming side data contents is a bad idea and should not be done
> at all. It's supposed to be an in-memory representation, which is
> inherently platform-dependent - besides endianness there are potential
> issues with padding or type sizes. If we want to test side data, we
> should use some other mechanism for it (e.g. ffprobe).

I agree with this take, but I think you are only grazing the tip of the
iceberg here.

I think than whenever we add a simple type (enum or structure) for use
as a side-data structure, frame property or similar, we should add a set
of function to perform the basic operations, with standardized names and
prototype: freeing, copy/cloning, printing, possibly checksumming, etc.

Do you not agree it would be a worthy discipline?

(Of course, if we agree on it, we need to revisit existing types to give
them these functions too.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201216/98249941/attachment.sig>