[FFmpeg-devel] [PATCH 7/7] Handle AVID MJPEG streams directly in the MJPEG decoder.

[Michael Niedermayer]

On Sat, Dec 12, 2020 at 04:45:55PM +0100, Anton Khirnov wrote:
> AVID streams, currently handled by the AVRN decoder can be (depending on
> extradata contents) either MJPEG or raw video. To decode the MJPEG
> variant, the AVRN decoder currently instantiates a MJPEG decoder
> internally and forwards decoded frames to the caller (possibly after
> cropping them).
> 
> This is suboptimal, because the AVRN decoder does not forward all the
> features of the internal MJPEG decoder, such as direct rendering.
> Handling such forwarding in a full and generic manner would be quite
> hard, so it is simpler to just handle those streams in the MJPEG decoder
> directly.
> 
> The AVRN decoder, which now handles only the raw streams, can now be
> marked as supporting direct rendering.
> 
> This also removes the last remaining internal use of the obsolete
> decoding API.
> ---
>  libavcodec/avrndec.c  | 74 ++-----------------------------------------
>  libavcodec/mjpegdec.c | 11 +++++++
>  libavcodec/version.h  |  2 +-
>  libavformat/avidec.c  |  6 ++++
>  libavformat/isom.c    |  2 +-
>  libavformat/version.h |  2 +-
>  tests/fate/video.mak  |  2 +-
>  7 files changed, 23 insertions(+), 76 deletions(-)

breaks:
./ffmpeg -i ~/tickets/1527/24bpp.mov  whatever.mov

...
Press [q] to stop, [?] for help
[avrn @ 0x5625d111bbc0] packet too small
Error while decoding stream #0:0: Invalid data found when processing input
[avrn @ 0x5625d111bbc0] packet too small
Error while decoding stream #0:0: Invalid data found when processing input
[avrn @ 0x5625d111bbc0] packet too small
Error while decoding stream #0:0: Invalid data found when processing input
[avrn @ 0x5625d111bbc0] packet too small
...




[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201215/5e39b398/attachment.sig>