[FFmpeg-devel] [PATCH 3/3] tests/fate-run.sh: Don't overlook errors from md5 tests

Anton Khirnov anton at khirnov.net
Thu Dec 10 11:45:53 EET 2020


Quoting Andreas Rheinhardt (2020-12-04 23:57:40)
> The md5 test up until now ignored errors from ffmpeg (the cli) and just
> md5'ed whatever ffmpeg has output; while testing scenarios in which
> ffmpeg fails has its merits, errors should not be overlooked by default;
> doing so also reduces the effectiveness of sanitizers as errors from
> them are ignored. This has happened with a memleak in the AV1 decoder.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  tests/fate-run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list