[FFmpeg-devel] [PATCH] avcodec: set AV_CODEC_CAP_CHANNEL_CONF on decoders which set their own channels

Hendrik Leppkes h.leppkes at gmail.com
Sun Dec 6 01:37:12 EET 2020


On Sat, Dec 5, 2020 at 11:44 PM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Sat, Dec 05, 2020 at 11:41:23AM +0100, Hendrik Leppkes wrote:
> > The decoders in this set either have a fixed channel count, or read it
> > from the bitstream, and thus do not require the channel count as
> > external information.
> >
> > Fixes various regressions since
> > 81503ac58a763a36b1f57264013b1e76acb62b68, which requires a valid channel
> > count for decoders which do not set this capability.
>
> patch probably ok
>
> its a bit concerning that all these where missed by fate though
>

I primarily noticed this with pcm-bluray, which is in mpeg-ts and thus
has no container-level headers to fill in the missing information. Not
sure if we simply don't have that in FATE.
But any other of these codecs could theoretically suffer from this if
container info is missing, or avcodec is not fed the information by
eg. an API user.

- Hendrik


More information about the ffmpeg-devel mailing list