[FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

Xiang, Haihao haihao.xiang at intel.com
Fri Dec 4 15:20:58 EET 2020


On Fri, 2020-12-04 at 11:24 +0100, Anton Khirnov wrote:
> Quoting Haihao Xiang (2020-11-23 09:16:13)
> > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
> > used outside of lavc. In addition, ff_qsv_map_error is used in
> > libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it
> > static.
> > 
> > Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
> > ---
> 
> New avpriv functions are strongly discouraged. Dependencies between
> libavcodec and libavfilter are also not good.
> 
> Those should either be inline in a private header, or exported as proper
> public API from libavutil.
> 

Thanks for the comment, I will update the patch.

Regards
Haihao



More information about the ffmpeg-devel mailing list