[FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

Anton Khirnov anton at khirnov.net
Fri Dec 4 12:24:55 EET 2020


Quoting Haihao Xiang (2020-11-23 09:16:13)
> ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
> used outside of lavc. In addition, ff_qsv_map_error is used in
> libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it
> static.
> 
> Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
> ---

New avpriv functions are strongly discouraged. Dependencies between
libavcodec and libavfilter are also not good.

Those should either be inline in a private header, or exported as proper
public API from libavutil.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list