[FFmpeg-devel] [PATCH 04/13] avcodec/mss3: Remove unnecessary free of unallocated packet

Paul B Mahol onemda at gmail.com
Sun Aug 30 09:55:46 EEST 2020


On 8/30/20, Andreas Rheinhardt <andreas.rheinhardt at gmail.com> wrote:
> Paul B Mahol:
>> On 8/29/20, Andreas Rheinhardt <andreas.rheinhardt at gmail.com> wrote:
>>> The packet will only be allocated a few lines below.
>>>
>>
>> You mean frame?
>>
> Yes. Fixed locally. Thanks.

LGTM

>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>>> ---
>>>  libavcodec/mss3.c | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c
>>> index 113af5ba37..a301675ec2 100644
>>> --- a/libavcodec/mss3.c
>>> +++ b/libavcodec/mss3.c
>>> @@ -844,7 +844,6 @@ static av_cold int mss3_decode_init(AVCodecContext
>>> *avctx)
>>>                                              b_width * b_height);
>>>          if (!c->dct_coder[i].prev_dc) {
>>>              av_log(avctx, AV_LOG_ERROR, "Cannot allocate buffer\n");
>>> -            av_frame_free(&c->pic);
>>>              while (i >= 0) {
>>>                  av_freep(&c->dct_coder[i].prev_dc);
>>>                  i--;
>>> --
>>> 2.20.1
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list