[FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: More strictly check tag order

[Michael Niedermayer]

On Sat, Aug 29, 2020 at 11:00:13PM +0200, Paul B Mahol wrote:
> On 8/29/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > This is based on the encoder and a small number of CFHD sample files
> > It should make the decoder more robust against crafted input.
> > Due to the lack of a proper specification it is possible that this
> > may be too strict and may need to be tuned as files not following this
> > ordering are found.
> >
> 
> Breaks decoding of this and similar files:
> 
> https://samples.ffmpeg.org/V-codecs/CFHD/MT_BeartoothHighway_1min_Cineform.avi
> 
> It is too strict as our encoder does not implement 3d transforms.

fixed this and the othert files in that directory (will post a new patch
in a moment)

also subsequently after this patch somethig to check not just for
fields not being in the wrong place we also should probably check for
mandatory fields being not missing.
I assume for this too guessing from files & sdk & any other implementation
is the only option we have

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200830/6df9a030/attachment.sig>