[FFmpeg-devel] [PATCH 13/19] avfilter/af_aiir: Avoid temporary buffer when drawing image

Nicolas George george at nsup.org
Tue Aug 25 20:27:05 EEST 2020


Andreas Rheinhardt (12020-08-25):
> When creating the output video, a temporary buffer is used whose elments
> are only used three times: Once to store a value in it, once more to add
> the value of the preceding element of the temporary buffer to the current
> element and once more to add the current i. element to the i. element of
> another bufffer; the two latter operations were performed in one loop,
> whereas the first was performed in a loop of its own.
> 
> Yet these loops can be combined and the temporary buffer avoided. All
> one needs to do is store the running total of the elements that
> currently are in the temporary buffer and keep the preceding value of
> the destination buffer (it is needed to calculate the next element of
> the current temporary buffer, i.e. it is needed to know by how much to
> increment the running total).

I think "i." is a germanism. I do not feel confident to judge the
contents this patch.

The other patches look good to me (except a long line in the commit
message of #17), but I only maintain amerge, probably wait a few days
for he others.

Thanks.

Regards,

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list