[FFmpeg-devel] [RFC PATCH v4 3/5] libavcodec/jpeg2000: Modify cleanup

[Michael Niedermayer]

On Tue, Aug 25, 2020 at 09:50:05AM +0530, gautamramk at gmail.com wrote:
> From: Gautam Ramakrishnan <gautamramk at gmail.com>
> 
> This patch makes the ff_jpeg2000_cleanup
> function take in an extra parameter which
> indicates whether it is called from the
> encoder or decoder.
> ---
>  libavcodec/j2kenc.c      | 2 +-
>  libavcodec/jpeg2000.c    | 2 +-
>  libavcodec/jpeg2000.h    | 2 +-
>  libavcodec/jpeg2000dec.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

"Modify cleanup" is a bit generic as description

something like
"Pass is_encoder flag into the ff_jpeg2000_cleanup function."

is probably a better 1 line description

also you could probably use av_codec_is_encoder() instead

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200825/476fd49f/attachment.sig>