[FFmpeg-devel] [PATCH 1/3] avfilter/graphparser: Fix leaks when parsing inputs fails

Nicolas George george at nsup.org
Sun Aug 23 12:48:36 EEST 2020


Andreas Rheinhardt (12020-08-23):
> parse_inputs() uses a temporary linked list to parse the labeled inputs
> of a filter; said linked list owns its elements (and their names). On
> success, the list of unlabeled inputs is appened to the end of the list
> of labeled inputs and the new list is returned; yet on failures, nothing
> frees the already existing elements of the temporary linked list, leading
> to a leak.
> 
> This can be triggered by e.g. using '-vf [v][' in the FFmpeg
> command-line tool.
> 
> This leak seems to exist since 4e781c25b7b1955d1a9a0b0771c3ce1acb0957bd.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

LGTM.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200823/add5783b/attachment.sig>


More information about the ffmpeg-devel mailing list