[FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

[Martin Storsjö]

Hej Moritz,

On Fri, 21 Aug 2020, Moritz Barsnick wrote:

> Patch version 2 attached, with added documentation.
>

LGTM, with one small nit:

> @@ -49,6 +50,7 @@ typedef struct TLSShared {
>      {"cert_file",  "Certificate file",                    offsetof(pstruct, options_field . cert_file), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \
>      {"key_file",   "Private key file",                    offsetof(pstruct, options_field . key_file),  AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \
>      {"listen",     "Listen for incoming connections",     offsetof(pstruct, options_field . listen),    AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = TLS_OPTFL }, \
> +    {"http_proxy", "set proxy to tunnel through when using HTTPS", offsetof(pstruct, options_field . http_proxy), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \
>      {"verifyhost", "Verify against a specific hostname",  offsetof(pstruct, options_field . host),      AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }

I'd remove the "when using HTTPS" bit here.

// Martin