[FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

[Alex Pokotilo]

>  Seems reasonable, any special reason to reorder av_freep(&sync)?
I want to combine "bs" and it's children structures disposal in the same
order as in

ff_qsv_encode where we have

#if QSV_VERSION_ATLEAST(1, 26)
        if (avctx->codec_id == AV_CODEC_ID_H264) {
            enc_buf = bs->ExtParam;
            enc_info = (mfxExtAVCEncodedFrameInfo *)(*bs->ExtParam);
            ff_side_data_set_encoder_stats(&new_pkt,
                enc_info->QP * FF_QP2LAMBDA, NULL, 0, pict_type);
            av_freep(&enc_info);
            av_freep(&enc_buf);
        }
#endif
        av_freep(&bs);
        av_freep(&sync);


On Fri, Aug 21, 2020 at 11:59 AM Xiang, Haihao <haihao.xiang at intel.com>
wrote:

>
> Thanks for fixing the memory leak in qsv, it looks good to me.
>
> Thanks for review