[FFmpeg-devel] [PATCH 3/7] avfilter/formats: Resize potentially oversized arrays

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Thu Aug 20 00:47:51 EEST 2020


Nicolas George:
> Andreas Rheinhardt (12020-08-15):
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>  libavfilter/formats.c | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> The patch works, but I do not think it is necessary or even useful:
> these arrays are short-lived anyway, they will be freed very soon
> anyway.
> 
> (Also, we may want to make them power-of-two dynarrays at some places,
> to avoid quadratic adds of formats.)
> 
> Regards,
> 
I was unsure about this one and actually never liked it. I only did it
because the slight size increase is the only downside from patch two.
But you're right. It's dropped.

- Andreas


More information about the ffmpeg-devel mailing list