[FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

[Dale Curtis]

On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> Patch lacks the context for stream_size here - will it always be
> correct? Only asking since the check for the coede below this will
> have changed from avio_size(pb) to stream_size.
>

stream_size == avio_size(pb), just computed once at the top.


> Can mov_read_sidx not return an error?
>

Fixed.


> Needs two more spaces.
>

Done.


> Can be an else statement.
>

Can't be an else statement since the prior clause modifies is_complete.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sidx_fix_v1.patch
Type: application/octet-stream
Size: 2216 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200817/502b9fb5/attachment.obj>