[FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

Paul B Mahol onemda at gmail.com
Fri Aug 14 22:13:32 EEST 2020


On 8/14/20, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 14/08/2020 19:01, James Almer wrote:
>> On the very first email from this thread, he said "Please review and/or
>> benchmark, especially .asm file". He did not state his benchmarks were
>> irrelevant at first, but he did ask others for theirs.
>
> Resending because I accidentally replied to James instead of the list.
> Woops.
>
> I guess it was not clear to me this is not the initial thread, since it is
> not
> a v2 patch, and no other thread is titled this, or seems to include SIMD?
> Perhaps
> I missed it.
>
> I still cannot actually locate any benchmarks in the various CFHD threads.
> If any were
> done, as would be needed, to, like... test ones own SIMD code, they should
> be included
> in the commit messages.

Results differs between various CPUs and environments and also depends on
encoded file resolution and quality.

With my local patch I get overall several percent speed increase with
only horiz_filter SSE2 applied.
I also work on vert_filter SSE2 code, which currently give big speedup
with lowest quality encodings and higher resolutions.

For example:

best quality 1080 60fps progressive yuv422p10 with additonal WIP
vertical filter:
cpuflags 0 speed : 0x243x realtime
cpuflags sse2 speed: 0x353x realtime

worst quality 1080 60fps progressive yuv422p10 with additional WIP
vertical filter:
cpuflags 0 speed: 0x348x realtime
cpuflags sse2 speed: 0x811x realtime

Also I want reviews to be technical as possible, i have not sent this patch
to listen to bad remarks but to get more improvements in assembly code
if possible.

If you are not assembly developer and are not willing to test patches better to
stay away from this thread.

>
> (Nice that we still silently ignore various insults from Paul thrown around
> by the way.)

What specific insults in this thread?

>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list