[FFmpeg-devel] [PATCH] lavfi: check the validity of formats lists.

Nicolas George george at nsup.org
Fri Aug 14 11:37:55 EEST 2020


Michael Niedermayer (12020-08-14):
> this 
> ffplay -nostats mm-short.mpg -t 1 -af volume=replaygain=track,ebur128 -nodisp -autoexit
> 
> gets stuck with the patch, seems not depend on the input sample

Thanks for the testing.

It reveals two bugs in ffplay:

- On buffersink, it sets both channel_layouts to { stereo } and
  channel_counts to { 2 }, which is redundant and should not be done,
  although it is not properly documented.

- audio_thread() exits, but ffplay does not.

I can both fix and mitigate the first problem, but I am not familiar
enough with the workings of ffplay to fix the threading issue, and it
should be fixed too, because this check is not the only possible cause
for a failure at this point.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200814/10df6722/attachment.sig>


More information about the ffmpeg-devel mailing list