[FFmpeg-devel] [PATCH v2 3/3] FATE: add fate test for minterpolate filter

[Nicolas George]

Hi. Replying to a very old patch already applied.

lance.lmwang at gmail.com (12019-09-14):
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  tests/fate/filter-video.mak             |  4 ++++
>  tests/ref/fate/filter-minterpolate-down |  6 ++++++
>  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 tests/ref/fate/filter-minterpolate-down
>  create mode 100644 tests/ref/fate/filter-minterpolate-up
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 0c6ee72..ab7b624 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
>  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
>  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
>  
> +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down

> +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1

The patch says minterpolate, but the test is an exact copy of the
framerate test, and still testing framerate. Please fix.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200813/48ced3b1/attachment.sig>