[FFmpeg-devel] [PATCH v2 1/4] avformat/argo_asf: don't check or probe file version

[Alexander Strasser]

Am 9. August 2020 14:33:26 MESZ schrieb Zane van Iperen <zane at zanevaniperen.com>:
>On Sun, 9 Aug 2020 09:29:16 +0200
>"Paul B Mahol" <onemda at gmail.com> wrote:
>
>> 
>> This is really bad practice.
>> 
>
>Usually I'd agree. However (and I've just checked this) all file
>versions are identical.
>
>Since this is an Argonaut Games format, I checked the version of all
>the
>ASF files in their most recent games. The only two versions found were
>1.2 and 2.1, both of which are already supported.
>
>Because this format is looong-dead, I see no harm in ignoring file
>version (especially if the muxer allows specifying arbitrary versions).

IMHO ignoring version in read_header might be OK in this case.

Another way would be erroring out and say use ignore_version option. Don't think it's necessary here, but would maybe be a bit more honest and we could ask for samples at the same time.

Probably more problematic is the part completely removing the check for known version from the probe function. Shouldn't that stay?


  Alexander

>I shall update the commit message accordingly.
>
>$ for i in ~/Desktop/staging/asf_music/*/*; do ./asfdump.py $i | jq
>._version; done | sort -u
>"1.2"
>"2.1"
>