[FFmpeg-devel] [PATCH 3/6] avformat/argo_asf: use ArgoASFContext in muxer

Zane van Iperen zane at zanevaniperen.com
Sat Aug 8 15:34:28 EEST 2020


On Sat, 8 Aug 2020 11:46:55 +0200
"Andreas Rheinhardt" <andreas.rheinhardt at gmail.com> wrote:

> >
> There is no point keeping data only used once in your context which is
> not what these contexts are there for. Coupled with patch 4/6 you are
> adding a const AVClass * to the context of the demuxer although the
> demuxer doesn't use it. 5/6 adds another field unused by the demuxer.
> All of this could be better handled by simply using a small, dedicated
> structure as context for the muxer.

Okay, I originally had patches for both, but I wasn't sure what was
preferred. I'll move it back to the dedicated structures. Will probably
make the following patches simpler too...

Zane



More information about the ffmpeg-devel mailing list