[FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

Moritz Barsnick barsnick at gmx.net
Fri Aug 7 09:39:31 EEST 2020


On Thu, Jul 30, 2020 at 22:58:56 +0800, lance.lmwang at gmail.com wrote:
>  #include "libavutil/dovi_meta.h"
> +#include "libavutil//mpegts_audio_desc_metadata.h"
                      ^^
A duplicate slash slipped in there.

> +    av_log(ctx, AV_LOG_INFO, "component_type_flag: %u, bsid_flag: %u, "
> +           "mainid_flag: %u, asvc_flag: %u, "
> +           "component_type: %u, bsid: %u, mainid: %u, asvc: %u",
> +           desc6a->component_type_flag, desc6a->bsid_flag,
> +           desc6a->mainid_flag, desc6a->asvc_flag,
> +           desc6a->component_type, desc6a->bsid, desc6a->mainid, desc6a->asvc);
> +}

Would it be more correct to just dump the actually existing values,
i.e. those whose flag is 1? (I understand the flags say whether the
value exists. What is printed for the value if it doesn't exist?)

Moritz


More information about the ffmpeg-devel mailing list