[FFmpeg-devel] [PATCH] fate: Update the test references for h264-skip-nokey and h264-skip-noparse after b48397e7b84864f2

[James Almer]

On 8/3/2020 10:26 AM, James Almer wrote:
> On 8/3/2020 9:45 AM, Michael Niedermayer wrote:
>> On Mon, Aug 03, 2020 at 09:54:41AM +0300, Martin Storsjö wrote:
>>> ---
>>>  tests/ref/fate/h264-skip-nointra | 86 ++++++++++++++++----------------
>>>  tests/ref/fate/h264-skip-nokey   | 86 ++++++++++++++++----------------
>>>  2 files changed, 86 insertions(+), 86 deletions(-)
>>
>> b48397e7b84864f2d4c70361a4c4bed93e826753 is wrong
>>
>> if you update the checksums this may become more difficult
>> to cleanup. Not sure just a feeling ...
>>
>> Please take a more carefull look at 
>> b48397e7b84864f2d4c70361a4c4bed93e826753
>>
>> it does not disable crc checks for layer 1 & 2 it removes reading the CRC
>> field 
>> try decoding 
>> fate-suite//wtv/law-and-order-partial.wtv
>>
>> it plays fine before but since b48397e7b84864f2d4c70361a4c4bed93e826753
>> its audio is broken
>>
>> Thanks
> 
> Then please revert it. It was pushed without a review or a patch sent to
> the ML, and evidently without even a FATE run.

Just reverted it myself, and also sent a (hopefully) correct version of
the change.