[FFmpeg-devel] [PATCH 3/6] avcodec: add adpcm_argo encoder

[Michael Niedermayer]

On Sun, Aug 02, 2020 at 10:21:06AM +0000, Zane van Iperen wrote:
> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
> ---
>  Changelog              |  1 +
>  doc/general.texi       |  2 +-
>  libavcodec/Makefile    |  1 +
>  libavcodec/adpcmenc.c  | 86 +++++++++++++++++++++++++++++++++++++++++-
>  libavcodec/allcodecs.c |  1 +
>  libavcodec/utils.c     |  1 +
>  libavcodec/version.h   |  2 +-
>  7 files changed, 91 insertions(+), 3 deletions(-)
[...]
> diff --git a/libavcodec/version.h b/libavcodec/version.h
> index f66919617a..a3f9f828ee 100644
> --- a/libavcodec/version.h
> +++ b/libavcodec/version.h
> @@ -28,7 +28,7 @@
>  #include "libavutil/version.h"
>  
>  #define LIBAVCODEC_VERSION_MAJOR  58
> -#define LIBAVCODEC_VERSION_MINOR  99
> +#define LIBAVCODEC_VERSION_MINOR 100
>  #define LIBAVCODEC_VERSION_MICRO 100

this appears to break fate

TEST    aac-is-encode
TEST    aac-ln-encode-128k
stddev:  616.12 PSNR: 40.54 MAXDIFF:12149 bytes:  1675800/  1679360
stddev: |616.12 - 622| >= 5
Test aac-ln-encode-128k failed. Look at tests/data/fate/aac-ln-encode-128k.err for details.
stddev:  524.55 PSNR: 41.93 MAXDIFF: 7888 bytes:  1675800/  1679360
stddev: |524.55 - 514| >= 10
tests/Makefile:255: recipe for target 'fate-aac-ln-encode-128k' failed
make: *** [fate-aac-ln-encode-128k] Error 1
make: *** Waiting for unfinished jobs....
Test aac-is-encode failed. Look at tests/data/fate/aac-is-encode.err for details.
tests/Makefile:255: recipe for target 'fate-aac-is-encode' failed
make: *** [fate-aac-is-encode] Error 1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200803/006e72fc/attachment.sig>