[FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

Nicolas George george at nsup.org
Wed Apr 29 19:55:33 EEST 2020


lance.lmwang at gmail.com (12020-04-29):
> Thanks, I catch your point now. Most of existing code haven't return ERROR, so I
> choose the same way to process it. If you think it's not OK, we'll change more
> code I think.

Maybe the other code needs to be fixed the same way. Maybe the other
code needs not return an error and this one does. Maybe your change is
actually valid.

You cannot know unless you first understand what the code does and what
it is supposed to do. You cannot program by imitation, it does not work.

And you have to test your changes: run a ffmpeg command line, make sure
the new code is triggered, and check the output file, compare it with
when the change is not triggered. If they are both correct, good. If one
is corrupted, then you know your change was bogus. And if you did not
test, then your change cannot be accepted.

Ideally we can trust regular contributors to have tested their changes
and run FATE before submitting patches.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200429/edac0b7e/attachment.sig>


More information about the ffmpeg-devel mailing list