[FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

[Michael Niedermayer]

On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote:
> Apr 28, 2020, 16:07 by dev at lynne.ee:
> 
> > Apr 28, 2020, 15:59 by mattias.wadman at gmail.com:
> >
> >>
> >>
> > Well, I consider CRC checking a part of correctly parsing ogg, so I think its best to leave it on
> > all the time.
> >
> 
> Did a new version of the patches.
> The first two are identical, save for some minor style tweaks.
> The last one now ensures the max page size, 65k, is available for seeking and speeds up
> decoding on new/replacement streams since the offset was incorrect.
> I think its worth it.
> 
> I'm also close to figuring out how to make chained Opus work, will send a patch once I do.
> 

This patchset seems to detect a crc error in:
Your patchset is probably correct in this as there are artifacts before, 
just reporting this as i noticed it.

./ffmpeg -i ~/tickets/2121/vlc-bug.oga c.wav

sample should be here: https://trac.ffmpeg.org/raw-attachment/ticket/2121/vlc-bug.oga

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200429/34748268/attachment.sig>