[FFmpeg-devel] [PATCH v4 6/9] lavc/libopenh264enc: separate svc_encode_init() into several functions

Martin Storsjö martin at martin.st
Mon Apr 27 23:02:18 EEST 2020


On Wed, 15 Apr 2020, Linjie Fu wrote:

> Separate the initialization procedure into different functions.
>
> Make it more readable and easier to be extended.
>
> Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> ---
> libavcodec/libopenh264enc.c | 283 +++++++++++++++++++++++++++-----------------
> 1 file changed, 174 insertions(+), 109 deletions(-)

I honestly don't see the point here. Yes, the init function is long, but 
you're moving code around and making it even 65 lines longer in total...

In which way is this easier to extend than the previous form?

// Martin



More information about the ffmpeg-devel mailing list