[FFmpeg-devel] [PATCH 1/8] lavc: Rename hwaccel.h to hwconfig.h

[Mark Thompson]

On 19/04/2020 15:21, Zhong Li wrote:
> Mark Thompson <sw at jkqxz.net> 于2020年4月13日周一 下午11:34写道：
>>
>> All of these encoders can accept libmfx surfaces directly in a hardware
>> frames context, or they can accept software frames if a suitable device
>> is supplied to use.
>> ---
>>  libavcodec/qsvenc.c       | 7 +++++++
>>  libavcodec/qsvenc.h       | 3 +++
>>  libavcodec/qsvenc_h264.c  | 1 +
>>  libavcodec/qsvenc_hevc.c  | 1 +
>>  libavcodec/qsvenc_jpeg.c  | 1 +
>>  libavcodec/qsvenc_mpeg2.c | 1 +
>>  libavcodec/qsvenc_vp9.c   | 1 +
>>  7 files changed, 15 insertions(+)
>>
>>...
> 
> LGTM
> 
On 23/04/2020 10:22, Lynne wrote:
> Apr 13, 2020, 16:33 by sw at jkqxz.net:
> 
>> This already applied to decoders as well as hwaccels, and adding encoder
>> support was going to make the name even more inaccurate.
>> ---
>>  libavcodec/cuviddec.c                | 2 +-
>>  libavcodec/decode.c                  | 2 +-
>>  libavcodec/h263dec.c                 | 2 +-
>>  libavcodec/h264dec.c                 | 2 +-
>>  libavcodec/hevcdec.c                 | 2 +-
>>  libavcodec/{hwaccel.h => hwconfig.h} | 6 +++---
>>  libavcodec/mediacodecdec.c           | 2 +-
>>  libavcodec/mjpegdec.c                | 2 +-
>>  libavcodec/mmaldec.c                 | 2 +-
>>  libavcodec/mpeg12dec.c               | 2 +-
>>  libavcodec/mpeg4videodec.c           | 2 +-
>>  libavcodec/pthread_frame.c           | 2 +-
>>  libavcodec/qsvdec.h                  | 2 +-
>>  libavcodec/rkmppdec.c                | 2 +-
>>  libavcodec/utils.c                   | 2 +-
>>  libavcodec/vaapi_h264.c              | 2 +-
>>  libavcodec/vaapi_hevc.c              | 2 +-
>>  libavcodec/vaapi_mjpeg.c             | 2 +-
>>  libavcodec/vaapi_mpeg2.c             | 2 +-
>>  libavcodec/vaapi_mpeg4.c             | 2 +-
>>  libavcodec/vaapi_vc1.c               | 2 +-
>>  libavcodec/vaapi_vp8.c               | 2 +-
>>  libavcodec/vaapi_vp9.c               | 2 +-
>>  libavcodec/vc1dec.c                  | 2 +-
>>  libavcodec/vdpau_h264.c              | 2 +-
>>  libavcodec/vdpau_hevc.c              | 2 +-
>>  libavcodec/vdpau_mpeg12.c            | 2 +-
>>  libavcodec/vdpau_mpeg4.c             | 2 +-
>>  libavcodec/vdpau_vc1.c               | 2 +-
>>  libavcodec/vdpau_vp9.c               | 2 +-
>>  libavcodec/vp8.c                     | 2 +-
>>  libavcodec/vp9.c                     | 2 +-
>>  32 files changed, 34 insertions(+), 34 deletions(-)
>>  rename libavcodec/{hwaccel.h => hwconfig.h} (97%)
>>
> 
> patchset reviewed, LGTM
> I can't believe this hasn't been implemented yet. The only way to guess what the encoder needs
> currently is by tokenizing the name with an underscore and giving the last part to av_hwdevice_find_type_by_name, and av_get_pix_fmt, which is beyond ridiculous and fragile.
> 
> I kind of need this, so could you push this soon? Its already been 10 days on the ML.

Applied, except the NVENC part which I can't test.

Thanks,

- Mark