[FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

[mypopy at gmail.com]

On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov <anton at khirnov.net> wrote:
>
> Quoting mypopy at gmail.com (2020-04-22 05:39:38)
> > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov <anton at khirnov.net> wrote:
> > >
> > > Quoting mypopy at gmail.com (2020-04-21 04:47:42)
> > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov <anton at khirnov.net> wrote:
> > > > >
> > > > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07)
> > > > > > I'd like to ask opinions whether a installed header for just one structure is a good idea.
> > > > >
> > > > > I see no problem with it. More smaller headers is better that a few big
> > > > > headers.
> > > > >
> > > > > Another issue is that this struct has no constructor and thus cannot be
> > > > > extended without breaking ABI.
> > > > >
> > > > This structure is part of API, so I can't find a simple way to extend
> > > > without break the ABI, I believe  there are similar problems for
> > > > AVSphericalMapping
> > >
> > > No, AVSphericalMapping does not have that problem since it has a
> > > constructor.
> > >
> > Will add a constructor av_dovi_alloc with static inline in the header
> > for this comment
>
> Making it inline would invalidate the whole point, which is to avoid
> embedding the size of the struct into the calling program.
>
I see, so please help to review
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1587530154-27795-3-git-send-email-mypopydev@gmail.com/