[FFmpeg-devel] [PATCH 1/3] lavu/pix_fmt: add new pixel format x2rgb10

[Wang, Fei W]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Vittorio Giovara
> Sent: Wednesday, April 22, 2020 11:02 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/pix_fmt: add new pixel format
> x2rgb10
> 
> On Tue, Apr 21, 2020 at 10:32 PM Wang, Fei W <fei.w.wang at intel.com>
> wrote:
> 
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Hendrik Leppkes
> > > Sent: Tuesday, April 21, 2020 4:08 PM
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/pix_fmt: add new pixel
> > format
> > > x2rgb10
> > >
> > > On Tue, Apr 21, 2020 at 9:53 AM Fei Wang <fei.w.wang at intel.com>
> wrote:
> > > >
> > > > The format is packed RGB with each channel 10 bits available and
> > > > include 2 bits unused.
> > > >
> > >
> > > The name of this pix_fmt seems very confusing, and the entire format
> > seems
> > > very specific. What is such a packed RGB format really good for in
> > ffmpeg?
> > This format is named as X2R10G10B10 in libva, but I think X2RGB10 is
> > more concise. There is similar format name defined in Gstreamer like
> RGB10A2.
> > Because there are lots of Codec/Filter based on third-party library in
> > ffmpeg, while in these library they may support some specific format
> > like P010/Y210/Y410.., so in Ffmpeg side it should support this kinds
> > of formats first, at least the definition.
> >
> 
> In my opinion, unless it's needed by a ffmpeg features or it's fully supported
> in swscale so that ffmpeg users may use it, it should not go in.
Yes, this format is need in ffmpeg-vaapi. And my another 2 patches is the 
implementation of swscale and ffmpeg-vaapi csc for this format.
> --
> Vittorio
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".