[FFmpeg-devel] [PATCH] avfilter/vf_v360: check the limit of in_pad and out_pad

Nicolas George george at nsup.org
Tue Apr 21 16:38:52 EEST 2020


Steven Liu (12020-04-21):
> When i set out_pad=1 it will Segmentation fault
> so i think it should check the limit value of the in_pad and out_pad
> 
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> ---
>  libavfilter/vf_v360.c | 4 ++++
>  1 file changed, 4 insertions(+)

Please don't guess. Find the exact cause of the crash. The value 1 is
allowed by the option system, it is therefore a priori supposed to work,
rejecting it somewhere else is not a proper fix.

> +        av_log(s, AV_LOG_ERROR, "pad should smaller than 1.0\n");

Also a missing verb.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200421/ab18f86a/attachment.sig>


More information about the ffmpeg-devel mailing list