[FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

Nicolas George george at nsup.org
Tue Apr 21 16:22:33 EEST 2020


Limin Wang (12020-04-21):
> I have checked with one of non-empty-moov.mp4, and have observed one byte difference 
> only(02 and 01).  I haven't tool to dump every box in detail. If you think it's necessary, 
> I can looked at the movenc muxer further and figure out which field it's.

You can use ffprobe to check the difference to be sure it is what you
think it is, no need for complex tools. If you do that for all the tests
that have changed and write it in the commit message, I have no more
objections.

> 
> [lmwang at vpn ffmpeg]$ hexdump -C non-empty-moov.mp4 > non-empty-moov.hex
> [lmwang at vpn ffmpeg]$ hexdump -C non-empty-moov1.mp4 > non-empty-moov1.hex
> [lmwang at vpn ffmpeg]$ diff non-empty-moov.hex non-empty-moov1.hex

As a side note, never use diff without the -u option, it is annoying to
read.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200421/48324ea6/attachment.sig>


More information about the ffmpeg-devel mailing list