[FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

[Nicolas George]

Limin Wang (12020-04-21):
> OK, below is the commit log, please help to review whether it's your expected log:
> 
> NOTE about the testing effect:
> subtitle packet will be marked as keyframe, it'll change below testing reference
> files:
> tests/ref/fate/binsub-movtextenc and tests/ref/fate/sub2video 
> 
> audio packet will be marked as keyframe, it'll change below testing reference file
> tests/ref/fate/movenc

You are writing in the future tense, meaning you are making a
prediction.

You need to explain what you did, and the results. For example, did you
re-run the tests with -w, as suggested in
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260837.html
to examine the files before and after the change?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200421/ce624cfa/attachment.sig>