[FFmpeg-devel] [PATCH] avformat/utils: Fix memleak when decoding subtitle in find_stream_info

Anton Khirnov anton at khirnov.net
Mon Apr 20 16:01:10 EEST 2020


Quoting Andreas Rheinhardt (2020-04-18 21:54:26)
> avformat_find_stream_info() may decode some frames to get stream
> information. And when it does this for subtitles, the decoded subtitles
> leak.
> 
> (Decoding subtitles was added in b1511e00f6fefde6cb31b2e17f7812cfac1c8bd6
> for PGS subtitles. When PGS subtitles originate from a container that
> exports every segment as a packet of its own, no output will be
> generated when decoding a packet, because not enough input is available.
> Yet when used with PGS subtitles in the Matroska form a single packet
> contains enough data to generate output. Yet said output is not freed,
> hence this leak.)
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---

Looks good.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list