[FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

Limin Wang lance.lmwang at gmail.com
Fri Apr 17 17:18:05 EEST 2020


ping for merge please.

On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavfilter/af_acrossover.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c
> index f70c50b..002f378 100644
> --- a/libavfilter/af_acrossover.c
> +++ b/libavfilter/af_acrossover.c
> @@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx)
>  
>          p = NULL;
>  
> -        av_sscanf(arg, "%f", &freq);
> +        if (av_sscanf(arg, "%f", &freq) != 1) {
> +            av_log(ctx, AV_LOG_ERROR, "Invalid syntax for frequency[%d].\n", i);
> +            return AVERROR(EINVAL);
> +        }
>          if (freq <= 0) {
>              av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive number.\n", freq);
>              return AVERROR(EINVAL);
> -- 
> 2.9.5
> 

-- 
Thanks,
Limin Wang


More information about the ffmpeg-devel mailing list