[FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Apr 14 05:12:43 EEST 2020


James Almer:
> On 4/13/2020 10:46 PM, Andreas Rheinhardt wrote:
>> This has happened when writing chapters: Both editions as well as
>> chapters are by default not hidden and given that we don't support
>> writing hidden chapters at all, we don't need to write said elements at
>> all. The same goes for ChapterFlagEnabled.
> 
> LGTM. I assume they were added because they are both listed as
> Mandatory, despite having a default value, so it may have been confusing
> and contradictory back then.
> 
Applied, thanks.

- Andreas


More information about the ffmpeg-devel mailing list