[FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit rate control select support

[Anton Khirnov]

Quoting Linjie Fu (2020-04-06 13:14:47)
> RC_BITRATE_MODE:
>     set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust
>     in RcCalculatePictureQp().
> 
> RC_BUFFERBASED_MODE:
>     use buffer status to adjust the video quality.
> 
> RC_TIMESTAMP_MODE:
>     bit rate control based on timestamp.
> 
> Default to use RC_QUALITY_MODE.
> 
> Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> ---
>  libavcodec/libopenh264enc.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 

Doesn't this functionality depend on what variables the user specified
explicitly (like qscale, max/min/avg bitrates, buffer sizes etc.).
Wouldn't it be better to choose the default RC type based on those, like
vaapi does it?

-- 
Anton Khirnov