[FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

[Limin Wang]

On Thu, Apr 09, 2020 at 07:57:14PM +0200, Nicolas George wrote:
> Limin Wang (12020-04-09):
> > My patch set try to make the loudnorm filter easy to use for end user if they
> > want to process the volume in two pass.
> 
> Yes: you are seeing a problem, and you want to fix it, that's fine.
> 
> But the problem you are seeing is part of a wider problem, and fixing
> the part you see will make fixing the whole problem harder.
> 
> We did things like that many time, and it always caused problems. Let us
> not do it again. Since your goal is "make things easier" and not "fix an
> exploitable crash", we can take time to do things properly.
> 
> >					  I have no clue how to make it common
> > yet.
> 
> Well, let us start discussing it right now.
> 
> There is JSON-specific code in af_loudnorm.c, there should not be, I
> think we should start here.
> 
> My opinion is we should rework ffprobe's writers and move them to lavu.
> That would be the first step.

If someone can rework the ffprobe writers with a helper function, I'm 
glad to use it. I'm not code maintainer, if no other developer review
my code and help to push it, then it's difficult to merge. The time cycle
is too long, so I have no plan to do such work.

> 
> What do you think?
> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


-- 
Thanks,
Limin Wang