[FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

[Nicolas George]

lance.lmwang at gmail.com (12020-04-09):
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  doc/filters.texi          |  3 +++
>  libavfilter/af_loudnorm.c | 54 +++++++++++++++++++++++++++++++++++++--
>  2 files changed, 55 insertions(+), 2 deletions(-)

NACK.

If we are doing something like that, we should be doing it in a way that
works for all filters that output statistics, not just one: common
options name and syntax, common code.

Doing it that way will only result in similar filters having different
features in a way that no user can understand.

Same for the compact output.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200409/275b5440/attachment.sig>