[FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

Steven Liu lq at chinaffmpeg.org
Thu Apr 9 12:47:15 EEST 2020



> 2020年4月9日 下午5:33,Nicolas George <george at nsup.org> 写道:
> 
> Steven Liu (12020-04-09):
>> I think every body have themselves reason to checking memory and remove the checking at here.
>> Whatever for me you can add them here for somebody copy, other body remove them 
>> some days(maybe long time later) some body remove remove the for unnecessary processing.
> 
> I don't understand what you are trying to say.
I said I don’t care about it here, because it don’t  is not affected the workflow, you can merge it if it can make you happy.
I have no reason objection it, and no reason agreed it.:D
> 
> The removal of the checks was done at the same time the string functions
> were twisted to make them accept NULL. Nobody would propose to re-remove
> them unless they are very familiar with the code.
> 
> As it is, the code path for the check has been made to start in
> libavformat, make a detour through libavutil and come back to
> libavformat. This is terrible.
> 
> Let us re-add proper, clear checks where they belong.
> 
> Regards,
> 
> -- 
>  Nicolas George

Thanks

Steven Liu



More information about the ffmpeg-devel mailing list