[FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

[Hendrik Leppkes]

On Wed, Apr 8, 2020 at 3:46 AM Limin Wang <lance.lmwang at gmail.com> wrote:
>
> On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote:
> > Hi
> >
> > Le 08/04/2020 à 12:33 am, Limin Wang a écrit :
> > >On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote:
> > >>Hi
> > >>
> > >>new patch for latency option following the comments from N. George.
> > >I recall I had submit a patchset for related option incliding latency.
> > >https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200331140808.8839-2-lance.lmwang@gmail.com/
> >
> > hadn't spotted it; why was it not merged ?
> >
> >
> > >
> > >Why I haven't change to use AV_OPT_TYPE_DURATION, for the latency can
> > >be used in format srt://xxxx:port?latency=?, it's in unit of ms,
> > >in addition, AV_OPT_TYPE_DURATION is in unit of second default, it'll
> > >break the old user.
> > i tested with ffmpeg.exe; the change to
> >
> > AV_OPT_TYPE_DURATION
> >
> > didn't seem to break anything.
> >
> > The default is still set to whatever the libsrt API has set (120 ms
> > for transtype=live).
> >
> > Can you produce code broken by that change ?
>
> What's your command line?
> I recall If use AV_OPT_TYPE_DURATION for option, the default is in unit of second if your
> don't add suffix of ms, us. However the old is us, so it'll cause old user
> setting broken.
>

Any change to the options, including the original patch, would require
users to adjust, would it not?
If we require them to adjust anyway, then using AV_OPT_TYPE_DURATION
is the proper choice.

- Hendrik