[FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

[Paul B Mahol]

On 4/7/20, James Almer <jamrial at gmail.com> wrote:
> On 4/7/2020 2:55 PM, Paul B Mahol wrote:
>> On 4/7/20, Anton Khirnov <anton at khirnov.net> wrote:
>>> Quoting Paul B Mahol (2020-04-07 16:29:23)
>>>> On 4/7/20, Anton Khirnov <anton at khirnov.net> wrote:
>>>>> Quoting Paul B Mahol (2020-04-06 16:27:54)
>>>>>> On 4/6/20, James Almer <jamrial at gmail.com> wrote:
>>>>>>> On 4/6/2020 7:01 AM, Paul B Mahol wrote:
>>>>>>>> On 3/20/20, Paul B Mahol <onemda at gmail.com> wrote:
>>>>>>>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>>>>>>>> ---
>>>>>>>>>  configure               |    1 +
>>>>>>>>>  libavcodec/Makefile     |    1 +
>>>>>>>>>  libavcodec/allcodecs.c  |    1 +
>>>>>>>>>  libavcodec/avcodec.h    |    1 +
>>>>>>>>>  libavcodec/bink2.c      |  869 ++++++++++++++++++++++++++++
>>>>>>>>>  libavcodec/bink2f.c     | 1125
>>>>>>>>> ++++++++++++++++++++++++++++++++++++
>>>>>>>>>  libavcodec/bink2g.c     | 1197
>>>>>>>>> +++++++++++++++++++++++++++++++++++++++
>>>>>>>>>  libavcodec/codec_desc.c |    7 +
>>>>>>>>>  libavformat/bink.c      |    3 +-
>>>>>>>>>  9 files changed, 3203 insertions(+), 2 deletions(-)
>>>>>>>>>  create mode 100644 libavcodec/bink2.c
>>>>>>>>>  create mode 100644 libavcodec/bink2f.c
>>>>>>>>>  create mode 100644 libavcodec/bink2g.c
>>>>>>>>>
>>>>>>>>
>>>>>>>> Will apply soon!
>>>>>>>
>>>>>>> You need to first send an updated patch with the bug/leak fixes that
>>>>>>> people reported applied, so it can be confirmed they are ok.
>>>>>>
>>>>>> I fixed all bugs. gonna apply ASAP!
>>>>>
>>>>> This behaviour is utterly unacceptable.
>>>>>
>>>>
>>>> You wish, you ignore fact that I lost so much time in developing this
>>>> decoder,
>>>
>>> "lost"? If you consider that time lost then why did you do it at all?
>>
>> Because how would I know upfront that I would get so many negative reviews
>> which mostly nitpick stuff around?
>
> Can you point what review was negative? Because what i saw was praise,
> suggestions you could (and apparently did) ignore, plus bug reports.
> Take for example Peter Ross' first review. It started with a line
> congratulating you for writing this decoder, then mentioned a couple
> tables that were duplicated and you could reuse. And what was your
> reaction? Saying you'd ignore everything and calling his review useless.
> Not to mention how you told me I'm "in no position to tell you what to
> do" when i gave my own non-blocking suggestions. That's probably the
> biggest WTF I've ever seen coming from you.
>
> I don't know if you're trolling for fun, want attention, have trouble
> reading intent on people's emails, or you truly have a distorted
> perception of reality, but your fuse seemingly blows at merely being
> told anything other than LGTM. And it's getting way beyond tiresome and
> unacceptable.
>

I can not reuse tables that easily.

>>
>>>
>>>> to need tolerate such bikesheds from "friendly" developers.
>>>
>>> Why should the other developers lose their time arguing with you? Or why
>>> should they tolerate your constant blatantly belligerent behaviour.
>>>
>>> I should point out that reviewing is hard, time-consuming, unrewarded,
>>> and underappreciated - yet incredibly important. You should be grateful
>>> that people spend their time reading your code rather than attack or
>>> disregard them.
>>>
>>> --
>>> Anton Khirnov
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".